Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-18797

CircleCI: Fix BASE_BRANCH in generate.sh for cassandra-5.0

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Normal
    • Resolution: Fixed
    • 5.0-alpha1, 5.0
    • CI
    • None
    • Correctness
    • Low
    • Low Hanging Fruit
    • User Report
    • All
    • None
    • Hide

      Patch: https://github.com/ekaterinadimitrova2/cassandra/commit/4f212f5a791416d2bdd47c87eaa392af7bcfe3a2

      Tested locally like this:

       

      ./generate.sh -p
      Generating new config.yml file for paid tier from config_template.yml
      patching file ./config_template.yml
       
      Detecting new or modified tests with git diff --diff-filter=AMR cassandra-5.0...HEAD:
      
      
      
      Show
      Patch: https://github.com/ekaterinadimitrova2/cassandra/commit/4f212f5a791416d2bdd47c87eaa392af7bcfe3a2 Tested locally like this:   ./generate.sh -p Generating new config.yml file for paid tier from config_template.yml patching file ./config_template.yml   Detecting new or modified tests with git diff --diff-filter=AMR cassandra-5.0...HEAD:

    Description

      We have hardcoded BASE_BRANCH in the CircleCI script generate.sh. That one is used for the diff comparison when we detect new/changed tests.

      After adding cassandra-5.0, BASE_BRANCH needs to be updated from trunk to cassandra-5.0 in the newly created branch.

      Attachments

        Issue Links

          Activity

            People

              e.dimitrova Ekaterina Dimitrova
              e.dimitrova Ekaterina Dimitrova
              Ekaterina Dimitrova
              Andres de la Peña, Michael Semb Wever
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: