Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-19675

Avoid streams in the common case for UpdateTransaction creation

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Normal
    • Resolution: Fixed
    • 5.0, 5.1
    • Feature/SAI
    • None

    Description

      Some recent Accord profiling highlighted some easily addressable inefficiency in the way we create new UpdateTransaction objects in SecondaryIndexManager that have existed since the introduction of index groups for SAI. We should be able to clean this up by avoiding stream creation or even iteration over the groups when there is a single index group, which is going to be the most common case with SAI anyway. If we do have to iterate, there should also be no reason to copy the collection of index groups via listIndexGroups(), although that copying can remain in the method itself for external callers.

      Attachments

        1. new_update_txn_streams.png
          181 kB
          Caleb Rackliffe
        2. ci_summary-1.html
          160 kB
          Caleb Rackliffe
        3. ci_summary.html
          134 kB
          Caleb Rackliffe

        Issue Links

          Activity

            People

              maedhroz Caleb Rackliffe
              maedhroz Caleb Rackliffe
              Caleb Rackliffe
              David Capwell, Jeremiah Jordan
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h