[HBASE-21511] Remove in progress snapshot check in SnapshotFileCache#getUnreferencedFiles - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Resolved
Priority: Minor
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 3.0.0-alpha-1, 1.3.3, 2.2.0, 1.4.9, 2.1.2
Component/s: snapshots
Labels:
None

Hadoop Flags:

Reviewed

Description

During review of ~~HBASE-21387~~, Apache9 mentioned that the check for in progress snapshots in SnapshotFileCache#getUnreferencedFiles is no longer needed now that snapshot hfile cleaner and taking snapshot are mutually exclusive.

This issue is to address the review comment by removing the check for in progress snapshots.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending

21511.v3.txt
25/Nov/18 05:07
12 kB
Ted Yu
21511.v2.txt
25/Nov/18 02:08
12 kB
Ted Yu
21511.v1.txt
24/Nov/18 11:22
8 kB
Ted Yu
21511.branch-1.v4.txt
26/Nov/18 05:34
12 kB
Ted Yu
21511.branch-1.v3.txt
26/Nov/18 02:49
11 kB
Ted Yu

Issue Links

relates to

HBASE-21387 Race condition surrounding in progress snapshot handling in snapshot cache leads to loss of snapshot files

Resolved

HBASE-23202 ExportSnapshot (import) will fail if copying files to root directory takes longer than cleaner TTL

Resolved

HBASE-24442 Test coverage for HBASE-23202 - ExportSnapshot (import) will fail if copying files to root directory takes longer than cleaner TTL

Resolved

Activity

People

Assignee:: Ted Yu

Reporter:: Ted Yu

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 24/Nov/18 11:15

Updated:: 26/May/20 20:47

Resolved:: 26/Nov/18 05:50