Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-28408

Confusing logging during backup restore

    XMLWordPrintableJSON

Details

    • Reviewed

    Description

      Encountered this while experimenting with the backup/restore functionality.

      My setup was as follows:

      • Took several backups (Full1, inc2, inc3)
      • Changed an entry in the "lily_tenant_acme:LILY_SETTINGS" table
      • Attempt a restore (to test if my changed entry is reverted):
      $ hbase restore -conf backup-conf.xml s3a://backuprestore-experiments/hbase backup_1709123740345 -t "lily_tenant_acme:LILY_SETTINGS" -m "lily_tenant_acme:LILY_SETTINGS-restored1" -o
      
      24/02/28 16:15:41 WARN org.apache.hadoop.hbase.mapreduce.TableMapReduceUtil: The addDependencyJars(Configuration, Class<?>...) method has been deprecated since it is easy to use incorrectly. Most users should rely on addDependencyJars(Job) instead. See HBASE-8386 for more details.
      24/02/28 16:15:58 WARN org.apache.hadoop.hbase.tool.LoadIncrementalHFiles: Skipping non-directory hdfs://hdfsns/user/lily/hbase-staging/bulk_output-lily_tenant_acme-LILY_SETTINGS-restored1-1709136941410/_SUCCESS
      24/02/28 16:15:59 WARN org.apache.hadoop.hbase.backup.impl.RestoreTablesClient: Nothing has changed, so there is no need to restore 'lily_tenant_acme:LILY_SETTINGS'
      

      Based on the final logging line, I presumed my restore operation had failed.

      After some investigation however, I found that this was not the case: my change was reverted as expected.

      Some code investigation learned me this log message is shown because I was restoring backup `inc3`, and there were no changes between `full1` and `inc3`.

      I suggest rephrasing this log message, and changing it to a INFO level.

       

      Attachments

        Issue Links

          Activity

            People

              dieterdp_ng Dieter De Paepe
              dieterdp_ng Dieter De Paepe
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: