Uploaded image for project: 'Apache Ozone'
  1. Apache Ozone
  2. HDDS-7593 Supporting HSync and lease recovery
  3. HDDS-9365

[hsync] DataNode to deserialize Ratis transaction only once

    XMLWordPrintableJSON

Details

    Description

      Today DataNode deserializes request proto at every callback method: applyTransaction, applyTransaction, writeTransaction, readTransaction.

       

      For a transaction, the deserialzation happens more than 5 times (readTransaction happens twice for leader)

       

      It's super expensive. We should deserialize only once during preAppendTransaction() which takes place in parallel.

       

      TODO: I have a flame graph need to dig it up from my backlog.

      Attachments

        1. Screen Shot 2023-09-28 at 1.46.42 PM.png
          1.53 MB
          Wei-Chiu Chuang
        2. ozone_dn-weichiu-1.weichiu.root.hwx.site.html
          812 kB
          Wei-Chiu Chuang

        Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. HDDS-9369 Avoid deserializing OMRequest multiple times in OzoneManagerStateMachine

          • Major - Major loss of function.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. RATIS-1897 Make TransactionContext available in DataApi.write(..)

          • Major - Major loss of function.
          • Resolved
          requires

          Improvement - An improvement or enhancement to an existing feature or task. HDDS-9192 Update Ratis to 3.0.0

          • Blocker - Blocks development and/or testing work, production could not run
          • Resolved
          links to

          Web Link GitHub Pull Request #5752

          Activity

            People

              szetszwo Tsz-wo Sze
              weichiu Wei-Chiu Chuang
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: