Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-14999

Avoid Potential Infinite Loop in DFSNetworkTopology

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.3.1, 3.4.0
    • 3.3.1, 3.4.0
    • dfs
    • None
    • Reviewed

    Description

          do {
            chosen = chooseRandomWithStorageTypeAndExcludeRoot(root, excludeRoot,
                type);
            if (excludedNodes == null || !excludedNodes.contains(chosen)) {
              break;
            } else {
              LOG.debug("Node {} is excluded, continuing.", chosen);
            }
          } while (true);
      

      Observed this loop getting stuck as part of testing HDFS-14913.

      There should be some exit condition or max retries here

      Attachments

        1. HDFS-14999-01.patch
          5 kB
          Ayush Saxena

        Issue Links

          Activity

            People

              ayushtkn Ayush Saxena
              ayushtkn Ayush Saxena
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: