[HDFS-16585] Add @VisibleForTesting in Dispatcher.java after HDFS-16268 - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Resolved
Priority: Trivial
Resolution: Fixed
Affects Version/s: 3.4.0, 3.2.4, 3.3.5
Fix Version/s: 3.4.0, 3.2.4, 3.3.5
Component/s: balancer
Labels:
- pull-request-available

Target Version/s:

3.4.0, 3.2.4, 3.3.5
Hadoop Flags:

Reviewed

Description

The scope of a few methods were opened up by ~~HDFS-16268~~ to facilitate unit testing. We should annotate them with @VisibleForTesting so that they don't get used by production code.

The affected methods include:
PendingMove
markMovedIfGoodBlock
isGoodBlockCandidate

Attachments

Issue Links

links to

GitHub Pull Request #4337

Activity

People

Assignee:: Ashutosh Gupta

Reporter:: Wei-Chiu Chuang

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 20/May/22 17:30

Updated:: 11/Feb/24 10:41

Resolved:: 26/May/22 22:29

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

0.5h