Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9401

Fix findbugs warnings in BlockRecoveryWorker

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.8.0, 3.0.0-alpha1
    • None
    • None

    Description

      Noticed following findbug in HDFS-9400 

      Call to org.apache.hadoop.hdfs.server.protocol.DatanodeRegistration.equals(org.apache.hadoop.hdfs.protocol.DatanodeInfo) in org.apache.hadoop.hdfs.server.datanode.BlockRecoveryWorker$RecoveryTaskContiguous.recover()
Bug type EC_UNRELATED_TYPES (click for details) 
In class org.apache.hadoop.hdfs.server.datanode.BlockRecoveryWorker$RecoveryTaskContiguous
In method org.apache.hadoop.hdfs.server.datanode.BlockRecoveryWorker$RecoveryTaskContiguous.recover()
Actual type org.apache.hadoop.hdfs.protocol.DatanodeInfo
Expected org.apache.hadoop.hdfs.server.protocol.DatanodeRegistration
Value loaded from id
Value loaded from bpReg
org.apache.hadoop.hdfs.server.protocol.DatanodeRegistration.equals(Object) used to determine equality
At BlockRecoveryWorker.java:[line 116]

      https://builds.apache.org/job/PreCommit-HDFS-Build/13433/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html

      Attachments

        1. HDFS-9401-002.patch
          2 kB
          Brahma Reddy Battula
        2. HDFS-9401.patch
          1 kB
          Brahma Reddy Battula

        Issue Links

          is broken by

          Improvement - An improvement or enhancement to an existing feature or task. HDFS-9255 Consolidate block recovery related implementation into a single class

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. HDFS-9404 Findbugs issue reported in BlockRecoveryWorker$RecoveryTaskContiguous.recover()

          • Major - Major loss of function.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. HDFS-3837 Fix DataNode.recoverBlock findbugs warning

          • Major - Major loss of function.
          • Closed

          Activity

            People

              brahmareddy Brahma Reddy Battula
              brahmareddy Brahma Reddy Battula
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: