Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-4276

Remove dupicate Mesos constructor

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • None
    • None
    • Mesosphere Sprint 26
    • 1

    Description

      Mesos offers two almost-identical constructors

      // TODO(vinod): Remove this in favor of the below constructor.
      Mesos(const std::string& master,
            const std::function<void(void)>& connected,
            const std::function<void(void)>& disconnected,
            const std::function<void(const std::queue<Event>&)>& received);
      
      Mesos(const std::string& master,
            ContentType contentType,
            const std::function<void(void)>& connected,
            const std::function<void(void)>& disconnected,
            const std::function<void(const std::queue<Event>&)>& received);
      

      Here invocations of the first constructor can replaced trivially with
      invocations of the second one with contentType = ContentType::PROTOBUF.

      Attachments

        Activity

          People

            bbannier Benjamin Bannier
            bbannier Benjamin Bannier
            Till Toenshoff Till Toenshoff
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: