Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-6184

Health checks should use a general mechanism to enter namespaces of the task.

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Reviewable
    • Major
    • Resolution: Unresolved
    • None
    • None
    • None

    Description

      To perform health checks for tasks, we need to enter the corresponding namespaces of the container. For now health check use custom clone to implement this

        return process::defaultClone([=]() -> int {
    if (taskPid.isSome()) {
      foreach (const string& ns, namespaces) {
        Try<Nothing> setns = ns::setns(taskPid.get(), ns);
        if (setns.isError()) {
          ...
        }
      }
    }
    return func();
  });

      After the childHooks patches merged, we could change the health check to use childHooks to call setns and make process::defaultClone private again.

      Attachments

        Issue Links

          is blocked by

          Improvement - An improvement or enhancement to an existing feature or task. MESOS-6236 Launch subprocesses associated with specified namespaces.

          • Major - Major loss of function.
          • Reviewable
          is related to

          Bug - A problem which impairs or prevents the functions of the product. MESOS-7183 Always get coredump by add a health check on docker container app

          • Major - Major loss of function.
          • Resolved
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. MESOS-8037 ns::clone should spawn process, which is a direct child

          • Major - Major loss of function.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. MESOS-5070 Introduce more flexible subprocess interface for child options.

          • Major - Major loss of function.
          • Resolved

          Activity

            People

              Unassigned Unassigned
              haosdent@gmail.com haosdent
              Alex R Alex R
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated: