Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-8482

Signed/Unsigned comparisons in tests

    XMLWordPrintableJSON

Details

    • Mesosphere Sprint 73
    • 1

    Description

      Many tests in mesos currently have comparisons between signed and unsigned integers, eg

          ASSERT_EQ(4, v1Response->read_file().size());
      

      or comparisons between values of different enums, e.g. TaskState and v1::TaskState:

        ASSERT_EQ(TASK_STARTING, startingUpdate->status().state());
      

      Usually, the compiler would catch these and emit a warning, but these are currently silenced because gtest headers are included using the -isystem command line flag.

      Attachments

        Issue Links

          Activity

            People

              bennoe Benno Evers
              bennoe Benno Evers
              Benjamin Bannier Benjamin Bannier
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: