Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-5046

Remove the old estimation OSGi setting (compaction.gainThreshold)

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.5.12
    • 1.5.13, 1.6.0
    • segment-tar

    Description

      Currently, there are two implementations for finding out the gain in repository size after running compaction: the old one, CompactionGainEstimate and the new one, SizeDeltaGcEstimation. Similarly, there are also two configurations for customising them, in SegmentNodeStoreService, compaction.gainThreshold and compaction.sizeDeltaEstimation.

      At the moment both of them are exposed as OSGi configurations, but only the new one should be exposed (e.g. compaction.sizeDeltaEstimation).

      It must be evaluated whether it makes sense to keep the logic associated with the old implementation.

      Attachments

        1. OAK-5046-01.patch
          5 kB
          Andrei Dulceanu
        2. OAK-5046-02.patch
          20 kB
          Andrei Dulceanu
        3. OAK-5046-03.patch
          21 kB
          Andrei Dulceanu
        4. OAK-5046-04.patch
          23 kB
          Andrei Dulceanu
        5. OAK-5046-05.patch
          24 kB
          Andrei Dulceanu

        Issue Links

          Activity

            People

              adulceanu Andrei Dulceanu
              adulceanu Andrei Dulceanu
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: