Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-13115

Ofbiz performance issue with ThemeFactory

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Implemented
    • Upcoming Branch
    • Upcoming Branch
    • framework/widget
    • None

    Description

      If there are many products with images (images stored in the plugin or theme), the ThemeFactory blocks the frontend until all files are processed.

      The problem is initiated in the following lines of code in ThemeFactory.java:

      List<File> xmlThemes = FileUtil.findXmlFiles(themeFolderPath, null, "theme", "widget-theme.xsd");
              List<File> xmlPluginThemes = FileUtil.findXmlFiles(pluginsFolderPath, null, "theme", "widget-theme.xsd");

      I think the search path should be restricted to the "widget" folder of the respective plugins/themes, as the theme.xml file should be located there.

      Attachments

        1. themefactory.patch
          3 kB
          Ingo Wolfmayr

        Activity

          People

            jleroux Jacques Le Roux
            iwolf Ingo Wolfmayr
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: