CriteriaQuery instances should not change their state based on Query instances created from them

JPA has a two-step, programatic query creation process: first, you create a CriteriaQuery to build up the general query structure, add constraints on it etc. Then you take that instance and create a (Typed)Query instance from it using the currently available EntityManager and bind parameters to it.

According to reports we got for Spring Data JPA, the latter step changes the state of the CriteriaQuery instance, so that subsequent creations of Query instances from it (and subsequent parameter bindings in turn) don't actually get applied correctly.

Even if the subsequent creation and parameter binding got applied, that change of state in CriteriaQuery instances is problematic in concurrent access scenarios as the bindings might override each other partially.

Generally speaking I'd recommend to keep the CriteriaQuery instances immutable with regards to the creation of Query instances from them and the subsequent handling of those Query instances.