Uploaded image for project: 'ORC'
  1. ORC
  2. ORC-684

[C++] Make Floating point NaN check more strict

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.7.0
    • 1.7.0
    • None
    • None

    Description

      ORC-636 added an extra check (part of  RecordReaderImp) disabling PPD when DoubleColumnStats min, max or sum is a non-Finite number.

      However, the check is unnecessarily broad – the way stats are updated, using just sum for the check would suffice.

      Attachments

        Issue Links

          is a child of

          Bug - A problem which impairs or prevents the functions of the product. ORC-636 [C++] PPD Floating point stats with NaN should be ignored

          • Major - Major loss of function.
          • Closed
          links to

          Web Link GitHub Pull Request #565

          Activity

            People

              pgaref Panagiotis Garefalakis
              pgaref Panagiotis Garefalakis
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: