Uploaded image for project: 'REEF (Retired)'
  1. REEF (Retired)
  2. REEF-287

.NET Evaluator doesn't inform the Driver when it crashes early

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Duplicate
    • None
    • None
    • REEF.NET Evaluator
    • None

    Description

      As part of looking into REEF-276, I discovered the following code in Evaluator.cs:

      AppDomain.CurrentDomain.UnhandledException += UnhandledExceptionHandler;

      and:

      private static void UnhandledExceptionHandler(object sender, UnhandledExceptionEventArgs e)
        {
            Exception ex = default(Exception);
            ex = (Exception)e.ExceptionObject;
            _logger.Log(Level.Error, "Unhandled exception caught in Evaluator.", ex);
            Exceptions.Throw(new InvalidOperationException("Unhandled exception caught in Evaluator.", ex), _logger);
        }

      This doesn't seem to inform the Driver of the failure. YARN eventually does, but won't be able to send the exception along. We should send the exception to the Driver before exiting here.

      Attachments

        Issue Links

          blocks

          New Feature - A new feature of the product, which has yet to be developed. REEF-1207 REEF.NET Evaluator should print a known log line on exit

          • Major - Major loss of function.
          • Resolved
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. REEF-289 Rewrite .NET Evaluator with Tang

          • Major - Major loss of function.
          • Resolved
          is superceded by

          Improvement - An improvement or enhancement to an existing feature or task. REEF-1364 C# Evaluator should attempt to send a failure message back to the Driver on an unhandled Exception

          • Major - Major loss of function.
          • Resolved

          Activity

            People

              Unassigned Unassigned
              markus.weimer Markus Weimer
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: