Uploaded image for project: 'Shiro'
  1. Shiro
  2. SHIRO-109

RememberMeManager should have access to Subject context map

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.9-RC1, 0.9
    • 1.0.0
    • Subject, Web
    • None

    Description

      A bug surfacing in the ShiroFilter showed that WebUtils.bind* methods needed to be called before the WebSubject.Builder could be used. This is because the RememberMeManager does not accept a Subject context map from where it could receive the Request and Response objects, so it must look them up from the thread, which surfaces the fragility of assumptions made about the thread.

      Instead, the subject creation context map should be given to the RememberMeManager so it can use whatever it needs inside the map to use to lookup the identity if necessary.

      See http://www.mail-archive.com/shiro-dev@incubator.apache.org/msg00178.html for details.

      Attachments

        Activity

          People

            lhazlewood Les Hazlewood
            lhazlewood Les Hazlewood
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 3h
                3h