Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-10778

Address precommit WARNINGS

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 4.6
    • 8.6
    • clients - java
    • None

    Description

      During precommit we are seeing lots of warnings. Im turning this into an umbrella issue about getting precommit warnings out of the code in general. Yes, this will take a while.

      See SOLR-10809 for getting all warnings out of solr/core. I want to selectively have precommit fail when "some part" of the code is clean so we don't backslide, and solr/core was the finest granularity I could see how to change.

      If you read more of the comments here, you can see that there are some serious code refactoring that could be done. I'm electing to simply SuppressWarnings rather than re-arrange code at this point whenever the code is tricky. If anyone goes back in and tries to clean the code up, then can remove the annotation(s).

      Attachments

        1. notclosed.txt
          391 kB
          Erick Erickson
        2. dated-warnings.log
          52 kB
          Christine Poerschke
        3. dated-warnings
          0.7 kB
          Christine Poerschke

        Issue Links

          incorporates

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-11973 Fail compilation on warnings

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is a child of

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-10810 Examine precommit lint WARNINGs in non-test code

          • Major - Major loss of function.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-10809 Get precommit lint warnings out of Solr core

          • Major - Major loss of function.
          • Closed
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-10779 JavaBinCodec should use close consistently rather than having marshal() and close() call finish() (which closes the underlying stream)

          • Major - Major loss of function.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. LUCENE-7907 Ant precommit task WARNINGS about unclosed resources

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. LUCENE-9394 Fix or suppress compile-time warnings

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. LUCENE-9143 Add more static analysis and clean up resulting warnings/errors

          • Major - Major loss of function.
          • Resolved
          There are no Sub-Tasks for this issue.

          Activity

            People

              erickerickson Erick Erickson
              andrew.musselman Andrew Musselman
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 10h
                  10h