Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-6660 Improve the usability for the new Suggester
  3. SOLR-6246

Core fails to reload when AnalyzingInfixSuggester is used as a Suggester

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 4.8, 4.8.1, 4.9, 5.0, 5.1, 5.2, 5.3, 5.4
    • 6.4.1, 6.5, 7.0
    • SearchComponents - other
    • None

    Description

      LUCENE-5477 - added near-real-time suggest building to AnalyzingInfixSuggester. One of the changes that went in was a writer is persisted now to support real time updates via the add() and update() methods.

      When we call Solr's reload command, a new instance of AnalyzingInfixSuggester is created. When trying to create a new writer on the same Directory a lock cannot be obtained and Solr fails to reload the core.

      Also when AnalyzingInfixLookupFactory throws a RuntimeException we should pass along the original message.

      I am not sure what should be the approach to fix it. Should we have a reloadHook where we close the writer?

      Attachments

        1. SOLR-6246.patch
          19 kB
          Steven Rowe
        2. SOLR-6246-test.patch
          13 kB
          Steven Rowe
        3. SOLR-6246-test.patch
          2 kB
          Steven Rowe
        4. SOLR-6246-test.patch
          17 kB
          Varun Thacker
        5. SOLR-6246-test.patch
          12 kB
          Varun Thacker
        6. SOLR-6246.patch
          11 kB
          Varun Thacker

        Issue Links

          is broken by

          Bug - A problem which impairs or prevents the functions of the product. LUCENE-7670 AnalyzingInfixSuggester should not immediately open an IndexWriter over an already-built index

          • Major - Major loss of function.
          • Reopened
          is depended upon by

          Bug - A problem which impairs or prevents the functions of the product. SOLR-9435 Un-recoverable state while using AnalyzingInfixLookupFactory with collection RELOAD action

          • Major - Major loss of function.
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. SOLR-7747 BlendedInfixSuggester doesn't support Solr core reload

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. SOLR-9435 Un-recoverable state while using AnalyzingInfixLookupFactory with collection RELOAD action

          • Major - Major loss of function.
          • Closed
          is related to

          Bug - A problem which impairs or prevents the functions of the product. SOLR-7747 BlendedInfixSuggester doesn't support Solr core reload

          • Major - Major loss of function.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. LUCENE-7564 AnalyzingInfixSuggester should close its IndexWriter by default at the end of build()

          • Major - Major loss of function.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. SOLR-9435 Un-recoverable state while using AnalyzingInfixLookupFactory with collection RELOAD action

          • Major - Major loss of function.
          • Closed
          links to

          Web Link GitHub Pull Request #96

          Activity

            People

              sarowe Steven Rowe
              varun Varun Thacker
              Votes:
              31 Vote for this issue
              Watchers:
              34 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: