Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4359

Haxe compiler looks like it is producing incorrect code for map or set key that is binary type

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 0.10.0
    • 0.11.0
    • Haxe - Compiler
    • None
    • docker ubuntu-artful; autotools

    Description

      Static code analysis in the gcc 7.2 build under Ubuntu Artful pointed out a missing break that may be cause for alarm:

      https://github.com/apache/thrift/blob/master/compiler/cpp/src/thrift/generate/t_haxe_generator.cc#2554

      https://github.com/apache/thrift/blob/master/compiler/cpp/src/thrift/generate/t_haxe_generator.cc#2579

      It looks like if the type is a set or map, and the key is a binary, it will fall through to an integer for handling. This seems incorrect.

      Attachments

        Activity

          People

            jking3 James E. King III
            jking3 James E. King III
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: