Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-11144

ContainerShellWebSocket gives inaccurate log message saying "... closed!" before trying to close the session

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Trivial
    • Resolution: Unresolved
    • None
    • None
    • yarn
    • None

    Description

      Hello,

      While viewing the MAPREDUCE-4262, it seems that the logging statements might give inaccurate messages. 

      I also found another same issue: the in the line 143 of the file ContainerShellWebSocket, the log messages says "...  closed!". However, there are other closing actions (source code) after the logging statement, which means that the close is still not completed.

      Would it be better if we change the verb "closed" to "closing" to indicate the action is in progress? Or can we move the logging statement to the end of the method? 

       

      Related issue: https://issues.apache.org/jira/projects/YARN/issues/YARN-11143

      Attachments

        Activity

          People

            Unassigned Unassigned
            zisding Ding Ding
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: