Uploaded image for project: 'ActiveMQ Artemis'
  1. ActiveMQ Artemis
  2. ARTEMIS-1702

ConcurrentLongHashMap and ConcurrentLongHashSet should avoid volatile set cost on put/remove

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.5.0
    • 2.5.0
    • Broker
    • None

    Description

      ConcurrentLongHashSet/HashMap are making use of unecessary volatile store of size/capacity for modifier methods. 

      The current JVM implementation of volatile store for multicore x86 is making use of a StoreLoad barrier for this operation: the most expensive one.

      These volatile stores could be replaced by plain stores/lazySet ones with no effects on the correctness of those methods.

      Attachments

        Issue Links

          Activity

            People

              nigro.fra@gmail.com Francesco Nigro
              nigro.fra@gmail.com Francesco Nigro
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: