./artemis upgrade backup is not created properly / incomplete

When ./artemis upgrade is run, the backup files are written to a file named after their parent directory, and only the last file is included.

To reproduce, run the artemis:ubuntu-11 docker image for artemis 2.17 in tty mode.

Access the console, modify artemis.profile with new properties, e.g. for us we have several properties starting with RAVE_* that we pass into a second JAVA_ARGS line for injection into broker.xml

cd /opt/apache-artemis/bin

./artemis upgrade /var/lib/artemis-instance

Navigate to /var/lib/artemis-instance/old-config-bkp.0

Observe that etc and bin are files not directories.

cat etc to see that it contains artemis.profile. bootstrap.xml is not backed up.

There is a tmp directory which contains all files modified but does not contain their original state, the added parameters will be missing.