Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-12033

Validate casts from double literals to numeric during expression conversion.

Details

    • Improvement
    • Status: Resolved
    • P2
    • Resolution: Fixed
    • None
    • 2.29.0
    • dsl-sql-zetasql
    • None

    Description

      Numeric values in ZetaSQL are subject to constraints: they must fall within certain hardcoded limits, and the scale also cannot exceed 9. Currently we have stricter constraints than these when preparing the expression in BeamZetaSqlCalcRel due to BEAM-12046. However, to force BeamCalcRel to have correct behavior, we should check the constraints earlier, during expression conversion.

      https://github.com/google/zetasql/blob/697da738be2af3b6b9492c73c55616d8b9fed0b6/javatests/com/google/zetasql/ValueTest.java#L727-L745

      Attachments

        Issue Links

          Activity

            People

              ibzib Kyle Weaver
              ibzib Kyle Weaver
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1.5h
                  1.5h