Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-12253

Read.UnboundedSourceAsSDFRestrictionTracker doesn't use cache for readers in getProgress

Details

    • Bug
    • Status: Resolved
    • P2
    • Resolution: Fixed
    • None
    • 2.31.0
    • sdk-java-core
    • None

    Description

      https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java#L963

      In getProgress, if currentReader == null a new reader is constructed from the restriction checkpoint. I think that we should consult the reader cache as creating readers is sometimes expensive.

      I observed in Nexmark pipelines that readers were being created at this location.

      Attachments

        Issue Links

          Activity

            People

              scwhittle Sam Whittle
              scwhittle Sam Whittle
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 2h
                  2h