Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-13563

Generalize AWS client provider to be independent of client type

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Triage Needed
    • P3
    • Resolution: Fixed
    • None
    • 2.38.0
    • io-java-aws

    Description

      Currently each AWS IO uses its own client provider, in some cases also separate ones for sync and async clients.

      Besides adding lots of boilerplate code across these IOs, this makes it impossible to switch to an async implementation without breaking APIs. 

      The approach below would require only one common client provider to build all kinds of clients:

      public <BuilderT extends AwsClientBuilder<BuilderT, ClientT>, ClientT> ClientT buildClient(BuilderT builder) {
  if (endpoint != null) {
    builder.endpointOverride(URI.create(endpoint));
  }
  return builder
      .credentialsProvider(credentialsProvider)
      .region(Region.of(region))
      .build();
}

buildClient(DynamoDbClient.builder());
buildClient(DynamoDbAsyncClient.builder());
buildClient(S3Client.builder());
buildClient(S3AsyncClient.builder());
...

      Attachments

        Issue Links

          blocks

          Improvement - An improvement or enhancement to an existing feature or task. BEAM-13956 Serialize/deserialize StsClient when serializing/deserializing StsAssumeRoleCredentialsProvider

          • P3 - Non-urgent bugs, features, and improvements
          • Open
          fixes

          Improvement - An improvement or enhancement to an existing feature or task. BEAM-13206 Consolidate multiple levels of retries for AWS IOs

          • P3 - Non-urgent bugs, features, and improvements
          • Resolved
          is required by

          Improvement - An improvement or enhancement to an existing feature or task. BEAM-13824 Migrate SnsIO.write to async implementation

          • P2 - Default priority. Will be triaged and planned according to community practices.
          • Open
          relates to

          Bug - A problem which impairs or prevents the functions of the product. BEAM-13663 Fix AWS client configuration in AwsModule

          • P2 - Default priority. Will be triaged and planned according to community practices.
          • Triage Needed
          links to

          Web Link GitHub Pull Request #16657

          Web Link GitHub Pull Request #16760

          Activity

            People

              mosche Moritz Mack
              mosche Moritz Mack
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 10h 10m
                  10h 10m