Details
-
Bug
-
Status: Resolved
-
P2
-
Resolution: Fixed
-
2.6.0
-
None
Description
The testWrite in KuduIOTest has 2 typos which were committed in error.
The following code block
for (int i = 1; i <= targetParallelism + 1; i++) {
expectedWriteLogs.verifyDebug(String.format(FakeWriter.LOG_OPEN_SESSION, i));
expectedWriteLogs.verifyDebug(
String.format(FakeWriter.LOG_WRITE, i)); // at least one per writer
expectedWriteLogs.verifyDebug(String.format(FakeWriter.LOG_CLOSE_SESSION, i));
}
// verify all entries written
for (int n = 0; n > numberRecords; n++) {
expectedWriteLogs.verifyDebug(
String.format(FakeWriter.LOG_WRITE_VALUE, n)); // at least one per writer
}
Should have read:
for (int i = 1; i <= targetParallelism ; i++) {
expectedWriteLogs.verifyDebug(String.format(FakeWriter.LOG_OPEN_SESSION, i));
expectedWriteLogs.verifyDebug(
String.format(FakeWriter.LOG_WRITE, i)); // at least one per writer
expectedWriteLogs.verifyDebug(String.format(FakeWriter.LOG_CLOSE_SESSION, i));
}
// verify all entries written
for (int n = 0; n < numberRecords; n++) {
expectedWriteLogs.verifyDebug(
String.format(FakeWriter.LOG_WRITE_VALUE, n)); // at least one per writer
}
This has gone unnoticed because 1) the targetParallelism is a function of cores available, and the test uses 3 only (which is the min in DirectRunner) and 2) the incorrect > in the test simply meant the loop was not run.
Attachments
Issue Links
- links to
