Uploaded image for project: 'Bookkeeper'
  1. Bookkeeper
  2. BOOKKEEPER-862

Add tracing and stats to OrderedSafeExecutor for debugging slow tasks

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 4.4.0
    • bookkeeper-server
    • None

    Description

      Porting a change form the Twitter branch to improve stats and logging in OrderedSafeExecutor
      These changes have been helpful for us in debugging latency issues in Bookkeeper server/client
      Summary of changes is

      • add a config option for op stats
      • add stats for task execution time, task pending time
      • add a config option for logging a warning when an op takes longer than x micros
      • add toString implementations for submitted tasks so make it easier to track down slow ops
      • start using Builder for OrderedSafeExecutor
      • add a very simple test to make sure that the slow op logging path is exercised

      Most of this came from Sijie originally, with some changes from me

      Attachments

        1. ose_stats.patch
          116 kB
          Leigh Stewart
        2. ose_stats-rebase.patch
          29 kB
          Sijie Guo
        3. BOOKKEEPER-862.patch
          34 kB
          Sijie Guo
        4. BOOKKEEPER-862.patch
          35 kB
          Sijie Guo

        Activity

          People

            l4stewar Leigh Stewart
            l4stewar Leigh Stewart
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: