Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-5678

Calcite should reject date literals not satisfying Gregorian calendar, per SQL standard

    XMLWordPrintableJSON

Details

    Description

      RexToLixTranslator now process datetime input\output string representation through transformation between gregorian and julian [1] calendars , thus no exception is raised if incorrect string is passed, just smart transformation instead.

      [1] org.apache.calcite.avatica.util.DateTimeUtils#timestampStringToUnixDate

      create table t (i int not null, j timestamp);
insert into t values (1, '2013-20-14 00:00:00');
select * from t;

> +---+---------------------+
> | I | J                   |
> +---+---------------------+
> | 1 | 2014-08-16 00:00:00 |
> +---+---------------------+

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. CALCITE-5957 Valid DATE '1945-2-2' is not accepted due to regression

          • Blocker - Blocks development and/or testing work, production could not run
          • Open
          is related to

          Bug - A problem which impairs or prevents the functions of the product. CALCITE-5414 Use DateTimeUtils to correctly convert between java.sql types and Unix timestamps

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. CALCITE-5923 SqlOperatorTest using safeParameters are not using overridable fixture

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. IGNITE-15623 Sql. Reject erroneous datetime literals.

          • Major - Major loss of function.
          • Resolved
          links to

          Web Link GitHub Pull Request #218

          Activity

            People

              zstan Evgeny Stanilovsky
              zstan Evgeny Stanilovsky
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 10m
                  10m