Uploaded image for project: 'Camel'
  1. Camel
  2. CAMEL-10500

Camel-Git: Add allowEmpty commits option

Details

    • Improvement
    • Status: Resolved
    • Trivial
    • Resolution: Fixed
    • 2.18.0
    • 2.19.0
    • camel-git
    • None
    • Novice

    Description

      By default, JGit behaves differently than native git allowing empty commits. This first change is to add a new option to the GitEndpoint to be able to turn that option to false. I let it default to "true" in a first move to have backward compatibility but suggest we could default to "false" to match native git behaviour (git commit --allow-empty)

      This will raise an exception for empty commits, may be a silent mode to log warn would be a better option rather than doing error handling in camel.

      Attachments

        Issue Links

          Activity

            githubbot ASF GitHub Bot added a comment -

            GitHub user chenapan opened a pull request:

            https://github.com/apache/camel/pull/1284

            CAMEL-10500 Camel-Git: Add allowEmpty commits option

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/chenapan/camel master

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/camel/pull/1284.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #1284


            commit fa09f3ef6f74badb8b18f6a94d93921b743a1235
            Author: Olivier Antibi <olivier.antibi@crossing-tech.com>
            Date: 2016-11-20T21:43:15Z

            Add allowEmpty endpoint option

            commit 25a92fd0257106fe36a5e4bcb0e58268a8db777b
            Author: Olivier Antibi <olivier.antibi@crossing-tech.com>
            Date: 2016-11-21T10:31:28Z

            CAMEL-10500 : Camel-Git: Add allowEmpty commits option
            Formatting and check style


            githubbot ASF GitHub Bot added a comment - GitHub user chenapan opened a pull request: https://github.com/apache/camel/pull/1284 CAMEL-10500 Camel-Git: Add allowEmpty commits option You can merge this pull request into a Git repository by running: $ git pull https://github.com/chenapan/camel master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/1284.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1284 commit fa09f3ef6f74badb8b18f6a94d93921b743a1235 Author: Olivier Antibi <olivier.antibi@crossing-tech.com> Date: 2016-11-20T21:43:15Z Add allowEmpty endpoint option commit 25a92fd0257106fe36a5e4bcb0e58268a8db777b Author: Olivier Antibi <olivier.antibi@crossing-tech.com> Date: 2016-11-21T10:31:28Z CAMEL-10500 : Camel-Git: Add allowEmpty commits option Formatting and check style
            githubbot ASF GitHub Bot added a comment -

            Github user chenapan closed the pull request at:

            https://github.com/apache/camel/pull/1284

            githubbot ASF GitHub Bot added a comment - Github user chenapan closed the pull request at: https://github.com/apache/camel/pull/1284

            People

              acosentino Andrea Cosentino
              chenapan Olivier Antibi
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 2h
                  2h
                  Remaining:
                  Remaining Estimate - 2h
                  2h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified