[CASSANDRA-18267] keepbrief is not called - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Bug
Status: Resolved
Priority: Normal
Resolution: Fixed
Fix Version/s: 4.1.2, 5.0-alpha1, 5.0
Component/s: Build
Labels:
None

Bug Category:
Code
Severity:
Normal
Complexity:
Normal
Discovered By:
User Report
Platform:

All
Impacts:

None
Since Version:

4.1-alpha1
Source Control Link:

https://github.com/apache/cassandra/commit/bb36090fa0858456fb1ba80adf71fb3dc24a1aac https://github.com/apache/cassandra/commit/91f6a9aca8d3c22a03e68aa901a0b154d960ab07

Test and Documentation Plan:

Hide

Tested locally in both branches:

Ant command	No args	-Dcassandra.keepBriefBrief=true	-Dcassandra.keepBriefBrief=false
ant testclasslist	brief output	brief output	long output
ant testsome -Dtest.name=...	long output	brief output	long output
ant test	brief output	brief output	long output

Patch	CI
4.1	CircleCI
trunk	CircleCI

Show

Tested locally in both branches: Ant command No args -Dcassandra.keepBriefBrief=true -Dcassandra.keepBriefBrief=false ant testclasslist brief output brief output long output ant testsome -Dtest.name=... long output brief output long output ant test brief output brief output long output Patch CI 4.1 CircleCI trunk CircleCI

Description

Discovered in ~~CASSANDRA-18179~~

The keepbrief macro is never called in build.xml

And attempts to use it result in

Buildfile: /Users/mick/src/apache/cassandra/build.xml
    [javac] Compiling 5 source files to /Users/mick/src/apache/cassandra/build/test/classes
    [javac] /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/EchoEclipseProjectLibs.java:21: error: package org.apache.cassandra.io.util does not exist
    [javac] import org.apache.cassandra.io.util.File;
    [javac]                                    ^
    [javac] /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/EchoEclipseProjectLibs.java:23: error: package org.apache.commons.io does not exist
    [javac] import org.apache.commons.io.FilenameUtils;
    [javac]                             ^
    [javac] /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:26: error: package org.junit does not exist
    [javac] import org.junit.Test;
    [javac]                 ^
    [javac] /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:30: error: package org.reflections does not exist
    [javac] import org.reflections.Reflections;
    [javac]                       ^
    [javac] /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:31: error: package org.reflections.scanners does not exist
    [javac] import org.reflections.scanners.Scanners;
    [javac]                                ^
    [javac] /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:32: error: package org.reflections.util does not exist
    [javac] import org.reflections.util.ConfigurationBuilder;
    [javac]                            ^
    [javac] /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:38: error: cannot find symbol
    [javac]     private static final Reflections reflections = new Reflections(new ConfigurationBuilder()
    [javac]                          ^
    [javac]   symbol:   class Reflections
    [javac]   location: class TestNameCheckTask
    [javac] /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/EchoEclipseProjectLibs.java:38: error: cannot find symbol
    [javac]         echo.setFile(new File(".classpath").toJavaIOFile());
    [javac]                          ^
    [javac]   symbol:   class File
    [javac]   location: class EchoEclipseProjectLibs
    [javac] /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/EchoEclipseProjectLibs.java:52: error: cannot find symbol
    [javac]             String srcJar = FilenameUtils.getBaseName(jars[i]) + "-sources.jar";
    [javac]                             ^
    [javac]   symbol:   variable FilenameUtils
    [javac]   location: class EchoEclipseProjectLibs
    [javac] /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/EchoEclipseProjectLibs.java:53: error: cannot find symbol
    [javac]             String srcDir = FilenameUtils.concat(project.getProperty("build.test.dir"), "sources");
    [javac]                             ^
    [javac]   symbol:   variable FilenameUtils
    [javac]   location: class EchoEclipseProjectLibs
    [javac] /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/EchoEclipseProjectLibs.java:54: error: cannot find symbol
    [javac]             File srcFile = new File(FilenameUtils.concat(srcDir, srcJar));
    [javac]             ^
    [javac]   symbol:   class File
    [javac]   location: class EchoEclipseProjectLibs
    [javac] /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/EchoEclipseProjectLibs.java:54: error: cannot find symbol
    [javac]             File srcFile = new File(FilenameUtils.concat(srcDir, srcJar));
    [javac]                                ^
    [javac]   symbol:   class File
    [javac]   location: class EchoEclipseProjectLibs
    [javac] /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/EchoEclipseProjectLibs.java:54: error: cannot find symbol
    [javac]             File srcFile = new File(FilenameUtils.concat(srcDir, srcJar));
    [javac]                                     ^
    [javac]   symbol:   variable FilenameUtils
    [javac]   location: class EchoEclipseProjectLibs
    [javac] /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:38: error: cannot find symbol
    [javac]     private static final Reflections reflections = new Reflections(new ConfigurationBuilder()
    [javac]                                                        ^
    [javac]   symbol:   class Reflections
    [javac]   location: class TestNameCheckTask
    [javac] /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:40: error: cannot find symbol
    [javac]                                                                    .setScanners(Scanners.MethodsAnnotated, Scanners.SubTypes)
    [javac]                                                                                 ^
    [javac]   symbol:   variable Scanners
    [javac]   location: class TestNameCheckTask
    [javac] /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:40: error: cannot find symbol
    [javac]                                                                    .setScanners(Scanners.MethodsAnnotated, Scanners.SubTypes)
    [javac]                                                                                                            ^
    [javac]   symbol:   variable Scanners
    [javac]   location: class TestNameCheckTask
    [javac] /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:38: error: cannot find symbol
    [javac]     private static final Reflections reflections = new Reflections(new ConfigurationBuilder()
    [javac]                                                                        ^
    [javac]   symbol:   class ConfigurationBuilder
    [javac]   location: class TestNameCheckTask
    [javac] /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java:51: error: cannot find symbol
    [javac]         Set<Method> methodsAnnotatedWith = reflections.getMethodsAnnotatedWith(Test.class);
    [javac]                                                                                ^
    [javac]   symbol:   class Test
    [javac]   location: class TestNameCheckTask
    [javac] Note: /Users/mick/src/apache/cassandra/test/anttasks/org/apache/cassandra/anttasks/TestNameCheckTask.java uses unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
    [javac] 18 errors

BUILD FAILED

Attachments

Issue Links

is caused by

CASSANDRA-17234 Workaround the need to use ant script task in build.xml

Resolved

Testing discovered

CASSANDRA-18445 Fix flaky paxosRepairHistoryIsntUpdatedInForcedRepair

Resolved

Activity

People

Assignee:: Ekaterina Dimitrova

Reporter:: Michael Semb Wever

Authors:: Ekaterina Dimitrova

Reviewers:: Andres de la Peña, Michael Semb Wever

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 16/Feb/23 10:24

Updated:: 12/Sep/23 13:03

Resolved:: 13/Apr/23 14:37