Details
-
Bug
-
Status: Resolved
-
Normal
-
Resolution: Fixed
-
None
-
Correctness - Transient Incorrect Response
-
Critical
-
Normal
-
Code Inspection
-
All
-
None
-
Description
Importing SSTables w/ already built SAI components is pretty unproblematic. However, the case where we import SSTables without accompanying index components can be problematic in two ways, given the indexes are built after the SSTables themselves are added to the tracker:
1.) The new SSTables can be seen for reads on the base table before their attached indexes are built and ready to query in the index View.
2.) If a failure occurs in an index build, the import just leaves the index in a compromised state, and even though a failure to import will be reported to the user, the SSTables will be readable for queries on the base table.
If the index implementation allows it (and SAI does), SSTableImporter should make sure SSTable indexes are built before making SSTables visible as part of the base table. If an index build fails, the import should fail and it should appear to ongoing reads like it never happened, including the index continuing to be queryable.
Attachments
Issue Links
- causes
-
CASSANDRA-19017 Ensure that empty SAI column indexes do not fail on validation after full-SSTable streaming
- Resolved
-
CASSANDRA-19084 Test Failure: IndexStreamingFailureTest.testAvailabilityAfterFailed*EntireFileStreaming
- Resolved
- is duplicated by
-
CASSANDRA-18653 Avoid unnecessary index builds and validations
- Resolved
- is related to
-
CASSANDRA-18653 Avoid unnecessary index builds and validations
- Resolved
- links to