[CASSANDRA-19583] Make 0 work as 0+unit for all three config classes (DataStorageSpec, DurationSpec, DataRateSpec) - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Needs Committer
Priority: Normal
Resolution: Unresolved
Fix Version/s: 4.1.x, 5.0.x, 5.x
Component/s: Local/Config
Labels:
None

Complexity:
Low Hanging Fruit
Platform:

All
Impacts:

None
Test and Documentation Plan:

Hide

Added unit tests

Show
Added unit tests

Description

The inline docs say:

Setting this to 0 disables throttling.

However, on startup, we throw this error:

Caused by: java.lang.IllegalArgumentException: Invalid data rate: 0 Accepted units: MiB/s, KiB/s, B/s where case matters and only non-negative values a>
Apr 23 23:12:01 cassandra0 cassandra[3424]:         at org.apache.cassandra.config.DataRateSpec.<init>(DataRateSpec.java:52)
Apr 23 23:12:01 cassandra0 cassandra[3424]:         at org.apache.cassandra.config.DataRateSpec.<init>(DataRateSpec.java:61)
Apr 23 23:12:01 cassandra0 cassandra[3424]:         at org.apache.cassandra.config.DataRateSpec$LongBytesPerSecondBound.<init>(DataRateSpec.java:232)
Apr 23 23:12:01 cassandra0 cassandra[3424]:         ... 27 common frames omitted

We should allow 0 without a unit attached for data, duration, and data spec config parameters, as 0 is always 0 no matter the unit.

Attachments

Issue Links

links to

4.1 PR

5.0 PR

Trunk PR

Activity

People

Assignee:: Arun Ganesh

Reporter:: Jon Haddad

Authors:: Arun Ganesh

Reviewers:: Brandon Williams

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 23/Apr/24 23:16

Updated:: 04/Aug/24 20:28

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

0.5h