Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-12261

subdirectories deprecated warning always shows and stop fetch

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • None
    • None
    • cordova-lib
    • None
    • Any

    Description

      CB-11979 introduced a warning for using subdir with git url.
      But even there is no subdir, it still show the warning, or prevent fetch.

      Because the line of code `options.subdir = options.subdir || '.';`
      And `if (result[2]) options.subdir = result[2];` will not set subdir to empty
      Then `if(options.subdir) {` will always true since options.subdir is '.' by default.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              yyfearth@gmail.com Wilson Yang
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 1h
                  1h
                  Remaining:
                  Remaining Estimate - 1h
                  1h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified