Uploaded image for project: 'ManifoldCF'
  1. ManifoldCF
  2. CONNECTORS-1185

Bug in how HttpClient connection manager is used

Details

    Description

      The HttpClient team informs me that the way we've been setting socket timeouts will basically silently do nothing. This is because HttpClient will ONLY pay attention to socket and connection timeouts at the connection manager level. That has implications for connection pooling also, since our connection management must now be in complete sync with our repository/output connection management.

      Attachments

        1. CONNECTORS-1185-Solr-5.x.patch
          3 kB
          Ahmet Arslan

        Activity

          kwright@metacarta.com Karl Wright added a comment -

          RequestBuilder.setStaleConnectionCheck()

          has also been deprecated, and is now replaced by:

          ConnectionManager.setValidateAfterInactivity(int ms)

          This also apparently means that all usages of the former will do nothing until replaced with the latter.

          kwright@metacarta.com Karl Wright added a comment - RequestBuilder.setStaleConnectionCheck() has also been deprecated, and is now replaced by: ConnectionManager.setValidateAfterInactivity(int ms) This also apparently means that all usages of the former will do nothing until replaced with the latter.
          kwright@metacarta.com Karl Wright added a comment -

          r1672616 (trunk)

          kwright@metacarta.com Karl Wright added a comment - r1672616 (trunk)
          kwright@metacarta.com Karl Wright added a comment -

          r1672621 (dev_1x)

          kwright@metacarta.com Karl Wright added a comment - r1672621 (dev_1x)
          iorixxx Ahmet Arslan added a comment -

          Shouldn't we propagate this fix to our plugins?

          iorixxx Ahmet Arslan added a comment - Shouldn't we propagate this fix to our plugins?
          kwright@metacarta.com Karl Wright added a comment -

          Yes, we should, although it is much less likely that socket timeout will be an issue in the plugins.

          Please go ahead and commit to solr-5.x trunk though.

          kwright@metacarta.com Karl Wright added a comment - Yes, we should, although it is much less likely that socket timeout will be an issue in the plugins. Please go ahead and commit to solr-5.x trunk though.
          iorixxx Ahmet Arslan added a comment -

          r1674373 for solr-5.x-plugin-trunk

          iorixxx Ahmet Arslan added a comment - r1674373 for solr-5.x-plugin-trunk

          People

            kwright@metacarta.com Karl Wright
            kwright@metacarta.com Karl Wright
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: