Uploaded image for project: 'CXF'
  1. CXF
  2. CXF-8691

Logging Feature - Sensitive element with arrays

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 3.4.0, 3.5.1
    • 3.5.10, 3.6.5, 4.0.6
    • JAX-RS
    • Unknown

    Description

      Hi,

      I am trying to use the LoggingFeature within cxf-rt and hide sensitive element names.

      The code I use looks like the following:

       

      LoggingFeature loggingFeature = new LoggingFeature();
      loggingFeature.setLogBinary(false);
      loggingFeature.setPrettyLogging(true);
      loggingFeature.setLogMultipart(false);
      loggingFeature.addSensitiveElementNames(new HashSet<>(Arrays.asList("password")));
       

      Payload:

      private final String shortName;
      
      private final char[] password;
      

       

      Output:

       

      [services.MyWebservicePort.REQ_OUT] INFO  - REQ_OUT
          Address: http://<some-url>
          HttpMethod: POST
          Content-Type: application/json
          ExchangeId: 560b73ae-e7e0-4687-9674-19ee72995a08
          Headers: {Accept=text/plain, Accept-Encoding=gzip;q=1.0, identity; q=0.5, *;q=0, Content-Type=application/json}
          Payload: {"shortName":"UserName","password":["G","e","h","e","i","m","1","2","3","!"]} 

      As you can see, my password is not hidden in the output of the payload. It is important to mention, that the field "password" in my code is declared as a char-array.

      However, if I add "shortName" to the sensetiveElementNames, everything works as expected. The shortName is hidden (XXX), due to it beeing declared as a String.

      I looked at the source code an tracked the problem down to a regex. "password" is not found, as the value is an array (MarkSensetiveHelper.java)

       

      Attachments

        Activity

          People

            reta Andriy Redko
            fwshngtn Daniel
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated: