Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-2412

Refactor NetworkServerControlImpl

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • None
    • None
    • Network Server
    • None

    Description

      NetworkServerControlImpl is overly complex and serves several purposes. This makes it hard to penetrate the logic, to debug and to maintain.

      I propose (actually, I've alread done a whole lot) to tear it apart and move the current semantics into the following new classes:
      NetworkServer - the actual network server code
      NetworkAdminServer - the implementation of network administration commands (ping, shutdown etc)
      NetworkAdminClient - the client for network administration of Derby
      NetworkAdminProtocol - the administration command protocol (as opposed to the DRDA protocol)
      plus a couple of utility classes (common methods, common constants, error messaging, exceptions etc)

      Attachments

        1. derby-2412-v1.stat
          1 kB
          Bernt Johnsen
        2. derby-2412-v1.diff
          293 kB
          Bernt Johnsen

        Issue Links

          blocks

          Improvement - An improvement or enhancement to an existing feature or task. DERBY-2363 Add initial handshake on connection setup to determine server's required ssl support level and avoid client side attribute settings.

          • Major - Major loss of function.
          • Open
          relates to

          Bug - A problem which impairs or prevents the functions of the product. DERBY-2761 When maxthreads and timeslice is set, network server admin commands like shutdown etc. are not guaranteed to get through

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. DERBY-2933 When network server disconnects due to an I/O Exception it does not always log the exception that caused the error

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. DERBY-1465 NetworkServerControl.start() should throw an exception and not just print exceptions if the server fails to start

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            People

              Unassigned Unassigned
              bernt Bernt Johnsen
              Votes:
              2 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated: