Uploaded image for project: 'Derby'
  1. Derby
  2. DERBY-681

Eliminate the parser's rewriting of the abstract syntax tree for queries with GROUP BY and/or HAVING clauses

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 10.3.1.4
    • SQL
    • None

    Description

      If a query contains a GROUP BY or HAVING clause, the parser rewrites the abstract syntax tree, putting aggregates into a subselect and treating the HAVING clause as the WHERE clause of a fabricated outer select from the subquery. This allows the compiler to re-use some machinery since the HAVING clause operates on the grouped result the way that the WHERE clause operates on the from list. Unfortunately, this rewriting creates an explosion of special cases in the compiler after parsing is done. The rewriting is not systematically handled later on in the compiler. This gives rise to defects like bug 280. We need to eliminate this special rewriting and handle the HAVING clause in a straightforward way. This is not a small bugfix but is a medium sized project.

      Attachments

        1. followup.patch.txt
          2 kB
          Manish Khettry
        2. 681.patch3.txt
          81 kB
          Manish Khettry
        3. 681.patch2.txt
          84 kB
          Manish Khettry
        4. notes.txt
          8 kB
          Manish Khettry
        5. 681.patch.txt
          68 kB
          Manish Khettry

        Issue Links

          incorporates

          Bug - A problem which impairs or prevents the functions of the product. DERBY-280 Wrong result from select when aliasing to same name as used in group by

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          is related to

          Bug - A problem which impairs or prevents the functions of the product. DERBY-4063 Constraint causes wrong query result when using exists

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. DERBY-4071 AssertFailure when selecting rows from a table with CHARACTER and VARCHAR columns

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. DERBY-1861 Column ordering ASSERT when combining column references and expressions in same ORDER BY

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. DERBY-1624 use of direct column name rather than alias make aggregation fail (Hibernate depends on that)

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. DERBY-3303 ArrayIndexOutOfBoundsException at MergeSort.compare

          • Blocker - Blocks development and/or testing work, production could not run
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. DERBY-3231 Sorting on COUNT with OR and GROUP BY delivers wrong results.

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. DERBY-3257 SELECT with HAVING clause containing OR conditional incorrectly return 1 row - should return 2 rows - works correctly with 10.2 DB

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. DERBY-3764 Union Query fail on Derby 10.4.1.3

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. DERBY-3872 NullPoinerException thrown when INTEGER function used as a predicate in a WHERE clause of a SELECT .. GROUP BY .. HAVING statement

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. DERBY-4230 DatabaseMetaData.getColumns() returns extra column from view with group by and expression in SELECT list

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. DERBY-4450 GROUP BY in an IN-subquery inside HAVING clause whose select list is subset of group by columns, gives NPE

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. DERBY-3880 NPE on a query with having clause involving a join

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. DERBY-1624 use of direct column name rather than alias make aggregation fail (Hibernate depends on that)

          • Major - Major loss of function.
          • Closed

          Activity

            People

              mkhettry Manish Khettry
              rhillegas Richard N. Hillegas
              Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: