Uploaded image for project: 'Qpid Dispatch'
  1. Qpid Dispatch
  2. DISPATCH-1938

Unify .eslintrc settings

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.14.0
    • 1.15.0
    • Console
    • None

    Description

      Currently, there are two ESlint config files in the project. There is console/.eslintrc.json and there is eslint section in console/react/package.json. The latter is used in a GitHub CI job, the former is not. The former is more strict, actually does not match the codestyle of the project, at this point, and uses legacy syntax (e.g. "no-console": "on" does not work nowadays).

      The .eslintrc.json:

      {
        "env": {
          "browser": true,
          "node": true,
          "amd": true,
          "jquery": true
        },
        "extends": ["eslint:recommended", "plugin:patternfly-react/recommended"],
        "parserOptions": {
          "ecmaVersion": 6,
          "sourceType": "module",
          "ecmaFeatures": {
            "jsx": true
          }
        },
        "rules": {
          "indent": [
            "error",
            2
          ],
          "linebreak-style": [
            "error",
            "unix"
          ],
          "semi": [
            "error",
            "always"
          ],
          "no-console": "on",
          "no-debugger": 1
        }
      }
      

      Somebody should do something about it.

      Attachments

        Activity

          People

            jdanek Jiri Daněk
            jdanek Jiri Daněk
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: