Uploaded image for project: 'Apache Drill'
  1. Apache Drill
  2. DRILL-2692

Do not log errors more than once

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 0.8.0
    • Future
    • Execution - Flow
    • None

    Description

      When a failure occurs in the execution stack it will be logged up to 6 times in the server logs.

      For example trying to query a bad json (extra ':') file will cause the following events:

      • ScanBatch.next() logs a debug message "Failed to read the batch. Stopping..." and calls FragmentContext.fail()
      • FragmentContext.fail() logs an error message "Fragment Context received failure – Fragment: "
      • FragmentExecutor.run() calls internalFail() and logs an error message when calling ErrorHelper.logAndConvertError()
        "Error <error id>: <error message>"
      • Foreman.close() calls ErrorHelper.logAndConvertError() which logs an error message "Error <error id>: <error message>"
      • FragmentExecutor.closeOutResources() will throw a RuntimeException because it contains a non null deferredException (the original exception). This exception is caught in run() and a warning message is logged "Error while initializing or executing fragment"
      • FragmentExecutor.run() calls FragmentContext.fail() when it catches the RuntimeException which will log an error message "Fragment Context received failure – Fragment: "

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              adeneche Abdel Hakim Deneche
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: