Details
-
Improvement
-
Status: Open
-
Major
-
Resolution: Unresolved
-
None
-
None
-
None
Description
Serial connector seems to be adding a bit of structure for a cmd request/response protocol to a SerialDevice that's attached to a system via a SerialPort.
It's hard to make sense of it until seeing it used in samples.connectors.elm327.Elm327Streams (and elm327.runtime) and sample.connectors.odb2.Obd2Streams - that is, a particular cmd request/response protocol to a device connected via a serial port. And there's no sample implementation of SerialDevice or SerialPort in the repo.
At a high level it strikes me that the SerialConnector should offer a general SerialDeviceStreams at the conceptual level of the of Elm327Streams. And we really need some doc (or sample) of a SerialDevice/SerialPort.
And what about a non-periodic (non-poll) form of non-static cmd list invocation? e.g., sending commands in a TStream - something like static TStream<JsonObject> sendCommands(SerialDevice, TStream<Cmd>).
And maybe there are other forms of use of a serial device - e.g., maybe the device/port just emits records on its own, not a bounded response to a "cmd".