Uploaded image for project: 'Felix'
  1. Felix
  2. FELIX-4811

Optimize ConfigurationManager#listConfigurations

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • configadmin-1.8.0
    • configadmin-1.8.2
    • Configuration Admin
    • None

    Description

      The ConfigurationManager#listConfigurations is far from optimal.
      It iterates on all configurations, thereby creating a copy of the properties for each configuration. Then, for each configuration, filter#match() is called, which itself create a case insentive copy of the properties for matching.
      If you have quite a lot of configurations and quite a lof of SCR components, it can be quite time consuming.

      Attached is a YourKit profile view which shows that 90% of the time is spent into copying properties for nothing.

      Attachments

        1. yourkit.png
          166 kB
          Guillaume Nodet

        Activity

          gnodet Guillaume Nodet added a comment - - edited Possible patch at https://github.com/gnodet/felix/commit/d6bf5ae7a82094feb367f223a03da9644b3d996d
          gnodet Guillaume Nodet added a comment - Fixed with http://svn.apache.org/viewvc?view=revision&revision=1663369

          People

            gnodet Guillaume Nodet
            gnodet Guillaume Nodet
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: