Uploaded image for project: 'Felix'
  1. Felix
  2. FELIX-4848

Split ResolverImpl

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Won't Fix
    • resolver-1.0.0
    • None
    • Resolver
    • None
    • Patch

    Description

      ResolverImpl currently contains about 2300 lines of code. That is way too big for a single class.

      I looked into it and found that the checkDynamicPackageSpaceConsistency and checkPackageSpaceConsistency methods and their dependent methods form a nice subset. I would move that into a class ConsistencyCheck.

      Both would share all of the inner classes of ResolverImpl but nothing else.
      So I think i would make sense to move these inner classes to separate files.

      These changes should nicely split the classes into
      ResolverImpl : 1400 lines
      ConsistencyCheck : 600 lines

      Attachments

        1. FELIX-4848-1.patch
          43 kB
          Christian Schneider
        2. Dependencies in resolver package after patch.png
          41 kB
          Christian Schneider

        Issue Links

          Activity

            People

              Unassigned Unassigned
              cschneider Christian Schneider
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: