Uploaded image for project: 'Felix'
  1. Felix
  2. FELIX-6672

Potentially losing comment state between reads on CommentRemovingReader

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • cm.json-2.0.4
    • cm.json-2.0.6
    • None
    • None

    Description

      In more extensive testing on real world data I found a case that was not properly handled in the rewrite towards BufferedReader. If. a read ends between the first / and the subsequent / or * for comment start, the detection will currently fail.

      To fix this I refactored the detection logic that should now also be significantly better readable always capturing the previous char on class level allowing to check for char double char sequences that may be split by the reads.

      Attachments

        Issue Links

          Activity

            People

              rombert Robert Munteanu
              dsuess Dominik Süß
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: