Uploaded image for project: 'Apache Fineract'
  1. Apache Fineract
  2. FINERACT-987

Replace null values with zero for bigDecimal values

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Auto Closed
    • None
    • None
    • Savings

    Description

      While trying to resolve https://github.com/apache/fineract/pull/915, I stumbled upon 

      org.apache.fineract.portfolio.savings.domain.SavingsAccountCharge since first historized release unspecified
In class org.apache.fineract.portfolio.savings.domain.SavingsAccountCharge
In method org.apache.fineract.portfolio.savings.domain.SavingsAccountCharge.percentageOf(BigDecimal, BigDecimal)
Parameter value
At SavingsAccountCharge.java:[lines 540-548]
value must be non-null but is marked as nullable
This parameter is always used in a way that requires it to be non-null, but the parameter is explicitly annotated as being Nullable. Either the use of the parameter or the annotation is wrong.

      Seems to be related to this line of code

      which sets passes a null value to a method which does not handle null values. The reason for the use of null values is not clear to me but this is a glitch which be troublesome.

      Attachments

        Activity

          People

            Unassigned Unassigned
            kaze Yemdjih Kaze Nasser
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: