Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-10392 Remove legacy mode
  3. FLINK-11146

Get rid of legacy codes from ClusterClient

    XMLWordPrintableJSON

Details

    Description

      As StephanEwen mentioned in ML
      https://lists.apache.org/thread.html/cc46fde6f8b31d4e833b01e5814a9547c8a67ea3e08a31ec5d71145e@%3Cdev.flink.apache.org%3E
      , the client needs big refactoring / cleanup. It should use a proper HTTP client library to help with future authentication mechanisms.

      After an investigation I notice that the valid cluster clients are only MiniClusterClient and RestClusterClient. Legacy clients, StandaloneClusterClient and YarnClusterClient, as well as pre-FLIP-6 codes inside ClusterClient, should be removed as part of FLINK-10392. With this removal we arrive a clean stage where we can think how to implement a proper HTTP client more comfortably.

      1. StandaloneClusterClient is now depended on by LegacyStandaloneClusterDescriptor (the removal is tracked by FLINK-10700) and FlinkClient(part of flink-storm which is decided to be removed FLINK-10571). Also relevant tests need to be ported(or directly removed).

      2. The removal of YarnClusterClient should go along with FLINK-11106 Remove legacy flink-yarn component.

      3. Testing classes inheriting from ClusterClient need to be ported(or directly removed).

      4. Get rid of legacy codes inside ClusterClient it self, such as #run(JobGraph, ClassLoader)

      Besides, what is JobClient used for? I cannot find valid usages of it. (Till mentioned it at ML https://lists.apache.org/thread.html/ce99cba4a10b9dc40eb729d39910f315ae41d80ec74f09a356c73938@%3Cdev.flink.apache.org%3E)
      cc mxm till.rohrmann

      Attachments

        Issue Links

          is a child of

          Improvement - An improvement or enhancement to an existing feature or task. FLINK-10392 Remove legacy mode

          • Major - Major loss of function.
          • Closed
          is a parent of

          Sub-task - The sub-task of the issue FLINK-11507 Remove invalid test JobClientActorTest

          • Major - Major loss of function.
          • Closed

          Sub-task - The sub-task of the issue FLINK-11508 Remove invalid test AkkaJobManagerRetrieverTest

          • Major - Major loss of function.
          • Closed

          Sub-task - The sub-task of the issue FLINK-11509 Remove invalid test ClientConnectionTest

          • Major - Major loss of function.
          • Closed

          Sub-task - The sub-task of the issue FLINK-11511 Remove legacy class JobAttachmentClientActor

          • Major - Major loss of function.
          • Closed

          Sub-task - The sub-task of the issue FLINK-11512 Port CliFrontendModifyTest

          • Major - Major loss of function.
          • Closed

          Sub-task - The sub-task of the issue FLINK-11513 Port CliFrontendSavepointTest

          • Major - Major loss of function.
          • Closed

          Sub-task - The sub-task of the issue FLINK-11514 Port ClusterClientTest

          • Major - Major loss of function.
          • Closed

          Sub-task - The sub-task of the issue FLINK-11515 Port ClientTest

          • Major - Major loss of function.
          • Closed

          Sub-task - The sub-task of the issue FLINK-11540 Remove StandaloneClusterClient

          • Major - Major loss of function.
          • Closed
          is blocked by

          Sub-task - The sub-task of the issue FLINK-10700 Remove LegacyStandaloneClusterDescriptor

          • Major - Major loss of function.
          • Resolved

          Sub-task - The sub-task of the issue FLINK-11106 Remove legacy flink-yarn component

          • Major - Major loss of function.
          • Resolved

          Sub-task - The sub-task of the issue FLINK-10571 Remove support for topologies

          • Major - Major loss of function.
          • Closed
          links to

          Web Link GitHub Pull Request #7762

          Activity

            People

              tison Zili Chen
              tison Zili Chen
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m