Details
-
Improvement
-
Status: Open
-
Minor
-
Resolution: Unresolved
-
kubernetes
-
None
Description
In the class of [ServiceType|https://github.com/apache/flink/blob/bf60c8813598d3119375cec057930240642699d4/flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/services/ServiceType.java
now the code as below,in ServiceType.java
.endMetadata() .withNewSpec() .withType( kubernetesJobManagerParameters .getRestServiceExposedType() .serviceType() .getType()) .withSelector(kubernetesJobManagerParameters.getSelectors()) .addNewPort() .withName(Constants.REST_PORT_NAME)
since the process context is in class ServiceType，then the type of service type should get from the self class，Instead of from `kubernetesJobManagerParameters`
.endMetadata() .withNewSpec() .withType( // modify to this .getType()) .withSelector(kubernetesJobManagerParameters.getSelectors()) .addNewPort() .withName(Constants.REST_PORT_NAME)
i think that would be better
