Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-9581

Redundant spaces for Collect at sql.md

Details

    Attachments

      1. collect.png
        24 kB
        Sergey Nuyanzin

      Issue Links

        Activity

          githubbot ASF GitHub Bot added a comment -

          GitHub user snuyanzin opened a pull request:

          https://github.com/apache/flink/pull/6161

          FLINK-9581 Remove extra spaces to make COLLECT left aligned

            1. Brief change log

          extra spaces removed

            1. Does this pull request potentially affect one of the following parts:
          • Dependencies (does it add or upgrade a dependency): ( no)
          • The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
          • The serializers: ( no )
          • The runtime per-record code paths (performance sensitive): ( no )
          • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: ( no )
          • The S3 file system connector: ( no )
            1. Documentation
          • Does this pull request introduce a new feature? (no)
          • If yes, how is the feature documented? (not applicable)

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/snuyanzin/flink COLLECT_DOC_TYPO

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/6161.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #6161


          commit 009afd05bc1316f35dd9841ac6367aab101d2970
          Author: snuyanzin <snuyanzin@...>
          Date: 2018-06-13T17:30:26Z

          Remove trailing space to make COLLECT left aligned


          githubbot ASF GitHub Bot added a comment - GitHub user snuyanzin opened a pull request: https://github.com/apache/flink/pull/6161 FLINK-9581 Remove extra spaces to make COLLECT left aligned Brief change log extra spaces removed Does this pull request potentially affect one of the following parts: Dependencies (does it add or upgrade a dependency): ( no) The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) The serializers: ( no ) The runtime per-record code paths (performance sensitive): ( no ) Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: ( no ) The S3 file system connector: ( no ) Documentation Does this pull request introduce a new feature? (no) If yes, how is the feature documented? (not applicable) You can merge this pull request into a Git repository by running: $ git pull https://github.com/snuyanzin/flink COLLECT_DOC_TYPO Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/6161.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6161 commit 009afd05bc1316f35dd9841ac6367aab101d2970 Author: snuyanzin <snuyanzin@...> Date: 2018-06-13T17:30:26Z Remove trailing space to make COLLECT left aligned
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on the issue:

          https://github.com/apache/flink/pull/6161

          Thanks @snuyanzin!
          +1 to merge

          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on the issue: https://github.com/apache/flink/pull/6161 Thanks @snuyanzin! +1 to merge
          githubbot ASF GitHub Bot added a comment -

          Github user snuyanzin commented on the issue:

          https://github.com/apache/flink/pull/6161

          @fhueske thank you for review
          @tillrohrmann if you took #6258 and @fhueske reviewed this may be it also makes sense to take into 1.5.1?

          githubbot ASF GitHub Bot added a comment - Github user snuyanzin commented on the issue: https://github.com/apache/flink/pull/6161 @fhueske thank you for review @tillrohrmann if you took #6258 and @fhueske reviewed this may be it also makes sense to take into 1.5.1?
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on the issue:

          https://github.com/apache/flink/pull/6161

          Documentation fixes are usually not critical to include in a release because the docs are always built from the most recent release branch. So also documentation changes that are not included in a release will be published shortly after being committed.

          I'll merge this PR.

          Btw. it is OK to create a hotfix (i.e., a PR without creating a JIRA issue) for minor fixes like this.

          Thanks, Fabian

          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on the issue: https://github.com/apache/flink/pull/6161 Documentation fixes are usually not critical to include in a release because the docs are always built from the most recent release branch. So also documentation changes that are not included in a release will be published shortly after being committed. I'll merge this PR. Btw. it is OK to create a hotfix (i.e., a PR without creating a JIRA issue) for minor fixes like this. Thanks, Fabian
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/6161

          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6161
          fhueske Fabian Hueske added a comment -

          Fixed for 1.4.3 with cb4a8fa136495ec657c875e267db435fa16f479f
          Fixed for 1.5.1 with f7997af4368a7b5f424ea8495849647697e1ed28
          Fixed for 1.6.0 with 84fbbfe1258c6c9c9aed919946f9652f7198f96b

          fhueske Fabian Hueske added a comment - Fixed for 1.4.3 with cb4a8fa136495ec657c875e267db435fa16f479f Fixed for 1.5.1 with f7997af4368a7b5f424ea8495849647697e1ed28 Fixed for 1.6.0 with 84fbbfe1258c6c9c9aed919946f9652f7198f96b

          People

            Sergey Nuyanzin Sergey Nuyanzin
            Sergey Nuyanzin Sergey Nuyanzin
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: