Uploaded image for project: 'Giraph (Retired)'
  1. Giraph (Retired)
  2. GIRAPH-469

Cleanup GraphMapper

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • None
    • None
    • None

    Description

      I don't see why we even call a map() method seeing as we are overriding run(). We are clearly not particularly "mapreduce-y" so we should make it our entry point more clear than a map(). Also I think we should have something like a WorkerThread similar to MasterThread and clean up all of this to just creare whichever threads the node is assigned roles of.

      Link to review board:

      https://reviews.apache.org/r/8898/

      Attachments

        1. GIRAPH-469-5.patch
          90 kB
          Eli Reisman
        2. GIRAPH-469-4.patch
          97 kB
          Eli Reisman
        3. GIRAPH-469-3.patch
          99 kB
          Eli Reisman
        4. GIRAPH-469-2.patch
          96 kB
          Eli Reisman
        5. GIRAPH-469-1-eli-idea.patch
          90 kB
          Eli Reisman

        Issue Links

          is duplicated by

          Improvement - An improvement or enhancement to an existing feature or task. GIRAPH-76 Refactor worker logic from GraphMapper

          • Major - Major loss of function.
          • Resolved
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. GIRAPH-409 Refactor / cleanups

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. GIRAPH-472 Refactor MapFunctions enum to be more general

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            People

              initialcontext Eli Reisman
              nitay Nitay Joffe
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: