Uploaded image for project: 'Giraph (Retired)'
  1. Giraph (Retired)
  2. GIRAPH-531

EdgeIterables#getEdges() should reuse Edge objects

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Not A Problem
    • None
    • None
    • None
    • None

    Description

      Since some of our vertex implementations don't allow for mutating or keeping references to edges returned by Vertex#getEdges(), we can consider that part of the API and exploit it in other places.
      EdgeIterables#getEdges() currently creates a new Edge object at each iteration.
      We can reuse the object for efficiency.

      Note: this issue may become irrelevant depending on how we refactor the Vertex API (e.g. no distinction between Vertex and SimpleVertex).

      Attachments

        Issue Links

          Activity

            People

              apresta Alessandro Presta
              apresta Alessandro Presta
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: